Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bloom definitions for Sonic Colors #10837

Merged
merged 1 commit into from Jul 13, 2022
Merged

Add bloom definitions for Sonic Colors #10837

merged 1 commit into from Jul 13, 2022

Conversation

SilentHeII
Copy link
Contributor

Adds definitions to add or remove bloom to Sonic Colors.

Original
SNCE8P_2022-07-11_22-44-13

Native
SNCE8P_2022-07-11_22-44-48

Remove
SNCE8P_2022-07-11_22-44-29

Adds definitions to add or remove bloom to Sonic Colors.
@iwubcode
Copy link
Contributor

iwubcode commented Jul 12, 2022

@SilentHeII - thanks for this!

I am curious, how much of the game have you played? Have you noticed any issues?

With a different method, I know there was some issues with triggering the bloom fix for other EFB copies. This would often impact Sonic's feet: https://user-images.githubusercontent.com/5954931/148661121-33a11943-cdea-4aa6-a17e-f78d07d08949.png . Maybe graphics mods works around this issue. I had assumed Sonic Colors was one of the problematic games (along with Metroid Prime).

@SilentHeII
Copy link
Contributor Author

I've actually beaten this game long before, but I've been replaying a few levels with the bloom fix and noticed no errors. In fact, I was mostly replaying the game because I've had this long standing issue where loading any level for the first time causes a slight stutter, but then never again for any level. This person has the same issue. https://www.reddit.com/r/DolphinEmulator/comments/n8ipiu/sonic_colors_stuttering_while_loading_first_level/

Other than that, I can't say I've seen any artifacts revolving around the bloom fix.

@iwubcode
Copy link
Contributor

@SilentHeII - I'm surprised but that's great to hear!

Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested. Json LGTM

@JMC47
Copy link
Contributor

JMC47 commented Jul 13, 2022

@dolphin-emu-bot rebuild

@JMC47 JMC47 merged commit 385f010 into dolphin-emu:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants