Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoCommon: Properly mask fbfetch logic op emulation #10841

Merged
merged 1 commit into from Jul 13, 2022
Merged

VideoCommon: Properly mask fbfetch logic op emulation #10841

merged 1 commit into from Jul 13, 2022

Conversation

TellowKrinkle
Copy link
Contributor

@TellowKrinkle TellowKrinkle commented Jul 13, 2022 •
edited

Fixes fbfetch logic op emulation to mask to 8 bits (previously was left as 32-bit)

Fixes f-zero-missing-shadows.dff.zip on GPUs which used fbfetch to run logic ops (which runs draws with invert as the logic op)

OatmealDome
OatmealDome approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@OatmealDome OatmealDome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested linked fifolog on Mac Mini M1 and the shadows show up. I also tried fifologs of other logic op games (Kirby's Air Ride, Star Fox Adventure) and they continue to work fine.

@JMC47 JMC47 merged commit cb350ae into dolphin-emu:master Jul 13, 2022
@TellowKrinkle TellowKrinkle deleted the FBFetchLogicOpMasking branch July 13, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OatmealDome OatmealDome OatmealDome approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@TellowKrinkle @OatmealDome @JMC47