Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Bring SD card settings up to date with DolphinQt #10861

Merged
merged 2 commits into from Jul 23, 2022
Merged

Android: Bring SD card settings up to date with DolphinQt #10861

merged 2 commits into from Jul 23, 2022

Conversation

JosJuice
Copy link
Member

@mbc07
Copy link
Contributor

mbc07 commented Jul 16, 2022

I think it's a bit odd that "Convert Folder to File Now" and "Convert File to Folder Now" are list entries. Shouldn't them be proper buttons, like in the Cheat Editor and User Data activities?

@JosJuice
Copy link
Member Author

This is how actions are normally implemented in the settings – and I would like to point out that even the cheats activity uses this style for things like "Download Gecko Codes".

With that said, making actions in the settings look more like buttons may not be a bad idea, but if so it should be handled in a separate PR so we can move over all the existing actions at ocne.

JMC47
JMC47 approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@JMC47 JMC47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to work now.

@JMC47 JMC47 merged commit 3d7b66b into dolphin-emu:master Jul 23, 2022
11 checks passed
@JosJuice JosJuice deleted the android-new-sd branch July 23, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMC47 JMC47 JMC47 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @mbc07 @JMC47