Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CP/XF matrix indices mismatch panic alert to a warning #10867

Conversation

Pokechu22
Copy link
Contributor

https://bugs.dolphin-emu.org/issues/12977 indicates that this happens on startup of Spider-Man 2, even in single-core. I don't have the game, so I can't directly determine why this is happening, but presumably real hardware does not hang in this case, so we can make it less obtrusive.

https://bugs.dolphin-emu.org/issues/12977 indicates that this happens on startup of Spider-Man 2, even in single-core. I don't have the game, so I can't directly determine why this is happening, but presumably real hardware does not hang in this case, so we can make it less obtrusive.
@Pokechu22 Pokechu22 force-pushed the mismatched-cp-xf-matrix-index-warning branch from 046d6e0 to 6a7aa8f Compare July 23, 2022 16:01
@iwubcode
Copy link
Contributor

Outside of that game, does the stats database show any other games with this quirk? I'm wondering if any of them are real issues.

@Pokechu22
Copy link
Contributor Author

https://mon.dolphin-emu.org/d/rvvg02qGk/analytics-quirks-report?orgId=1 says 1.5K instances for Spider-Man 2 (GK2E52), 500 for Call of Duty 2: Big Red One (GQCE52), 200 for PAL Spider-Man 2 (GK2P52), 200 for Shrek SuperSlam (G2RE52), 160 for Paper Mario TTYD (G8ME01), etc. (These numbers are for the past week.) Spider-Man, COD, and Shrek are all published by activision, and Spider-Man and COD were both developed by Treyarch.

Based on the fifolog, the Spider-Man 2 case is the game doing something wrong, but I don't know about the others. Also, there isn't any clear indication as to if these are happening in dual-core only, or if it's also happening in single-core (that'd be a nice thing to have on the quirks report, but I don't know if that's feasible to include). TTYD in particular is odd to see, but it seems to show up on all of the mismatched lists.

In any case, this PR still leaves the quirk report enabled.

Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@AdmiralCurtiss AdmiralCurtiss merged commit 9a45a69 into dolphin-emu:master Jul 23, 2022
11 checks passed
@dolphin-emu dolphin-emu deleted a comment from chrisleigh-stack Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants