VideoCommon: Fix IsDualSrc check for dst blend factors #10868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Small fix for #10747
We don't use dual source blend for SrcColor and InvSrcColor, only SrcAlpha and InvSrcAlpha.
Fixes gpus using the
BUG_BROKEN_DUAL_SOURCE_BLENDINGbug on games that draw usingSrcColoras a blend factor without using any of the SrcAlpha-based factors.Found this after I made the same mistake in the Metal renderer. Don't know what games it affects (if any), as the game that broke in Metal (Mario Sunshine) also used Src1Alpha as its SrcBlendFactor (and therefore wouldn't be affected here).