Android: Add graphics mods support to GUI #10885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patches, AR codes and Gecko codes have an associated code that the GUI can show, but graphics mods don't.
ReadOnlyCheat will be used by graphics mods.
iwubcode
reviewed
Jul 23, 2022
|
|
||
| for (GraphicsModConfig& mod : mod_group->GetMods()) | ||
| { | ||
| // Group only mods shouldn't be shown |
There was a problem hiding this comment.
Part of me wonders if we should add a IsModVisibleInUI(const std::set<std::string>& groups) function to be used in Qt and Android. Unlikely to add more visibility features but if it was needed, it would be in one place.
There was a problem hiding this comment.
I've removed some redundant empty checks instead. The code now feels short enough that it might be fine to just leave it duplicated.
iwubcode
reviewed
Jul 23, 2022
| Java_org_dolphinemu_dolphinemu_features_cheats_model_GraphicsModGroup_load(JNIEnv* env, jclass, | ||
| jstring jGameId) | ||
| { | ||
| auto* config = new GraphicsModGroupConfig(GetJString(env, jGameId)); |
There was a problem hiding this comment.
Just curious, what cleans up these raw pointers?
There was a problem hiding this comment.
Java_org_dolphinemu_dolphinemu_features_cheats_model_GraphicsModGroup_finalize.
JosJuice
force-pushed
the
android-graphics-mods
branch
2 times, most recently
from
52b2b63
to
ba13ce6
Compare
JosJuice
force-pushed
the
android-graphics-mods
branch
from
ba13ce6
to
3bd2bca
Compare
iwubcode
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Because PR #10518 (graphics mods) was merged right before the previous progress report, I didn't have time to make graphics mods available in the Android GUI in time before the progress report. But let's get it merged in time for the next progress report, shall we?