Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogManager: Dynamically get last log type #10897

Merged
merged 1 commit into from Jul 27, 2022
Merged

LogManager: Dynamically get last log type #10897

merged 1 commit into from Jul 27, 2022
+4 −1

Conversation

Hibyehello
Copy link
Contributor

Adding this due to 14 days of on and off debugging all because of the last log type being wrong, this will just grab that last type automatically.

@Hibyehello Hibyehello changed the title Log manager: Dynamically get last log type LogManager: Dynamically get last log type Jul 26, 2022
@AdmiralCurtiss
Copy link
Contributor

how the heck did you manage to make 7 commits (including 2 merge commits) for a two line change

@phire
Copy link
Member

phire commented Jul 26, 2022

The real question is why did you not squash and force-push out of shame like the rest of us?

@Hibyehello
Copy link
Contributor Author

Hibyehello commented Jul 26, 2022 •
edited

well Lint ruined me

@phire phire merged commit 1ea0c77 into dolphin-emu:master Jul 27, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pokechu22 Pokechu22 Pokechu22 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@Hibyehello @AdmiralCurtiss @phire @Pokechu22