DSPHLE: Support padded versions of libasnd and libaesnd uCodes #10898
+37
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Here are some tests with the current libogc and also extremscorner/libogc2@5cf525b and extremscorner/libogc2@ac91c27.
modplayhas been edited to callAESND_Reset()beforeexit(0), which correctly results in a hang on DSP LLE and a warning log on DSP HLE for all versions other than the most recent libogc2 version. All have had their makefiles edited to haveLIBSuse~/dkp/libogc2/lib/wii/libaesnd.aor~/dkp/libogc2/lib/wii/libasnd.ainstead of-laesndor-lasnd. Before, the libogc2 versions would result in an unknown ucode CRC. audio_examples.zipI also tested https://wiibrew.org/wiki/OpenTTD and confirmed that its audio plays correctly now. (This is a lot easier to install now that the SD card folder support exists.)
As with #10892/#10793/#10763, I have notes regarding the commits corresponding to these ucode versions: asnd_ucode_pad_notes.zip aesnd_ucode_pad_notes.zip
Index of the above (for search)
Asnd:
Aesnd: