Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSPHLE: Support padded versions of libasnd and libaesnd uCodes #10898

Merged
merged 2 commits into from Jul 30, 2022

Conversation

Pokechu22
Copy link
Contributor

Here are some tests with the current libogc and also extremscorner/libogc2@5cf525b and extremscorner/libogc2@ac91c27. modplay has been edited to call AESND_Reset() before exit(0), which correctly results in a hang on DSP LLE and a warning log on DSP HLE for all versions other than the most recent libogc2 version. All have had their makefiles edited to have LIBS use ~/dkp/libogc2/lib/wii/libaesnd.a or ~/dkp/libogc2/lib/wii/libasnd.a instead of -laesnd or -lasnd. Before, the libogc2 versions would result in an unknown ucode CRC. audio_examples.zip

I also tested https://wiibrew.org/wiki/OpenTTD and confirmed that its audio plays correctly now. (This is a lot easier to install now that the SD card folder support exists.)

As with #10892/#10793/#10763, I have notes regarding the commits corresponding to these ucode versions: asnd_ucode_pad_notes.zip aesnd_ucode_pad_notes.zip

Index of the above (for search)

Asnd:

Hashes of Extrems/compiled.bin: ector dbbeeb61 crc eb11e980 adler 4a12c76d fletcher ffc46bba; 0606 bytes (0303 words)
Hashes of Extrems/compiled_pad.bin: ector bad876ef crc 5629d6d3 adler 8c50c76d fletcher 783c6bba; 0620 bytes (0310 words)
Hashes of Extrems/dsp_mixer.bin: ector bad876ef crc 5629d6d3 adler 8c50c76d fletcher 783c6bba; 0620 bytes (0310 words)
Hashes of Extrems/dsp_mixer_nopad.bin: ector dbbeeb61 crc eb11e980 adler 4a12c76d fletcher ffc46bba; 0606 bytes (0303 words)

Aesnd:

Hashes of Extrems6/compiled.bin: ector 84c680a9 crc 1b1beb1d adler 2d952c7f fletcher 24058e0e; 03e6 bytes (01f3 words)
Hashes of Extrems6/compiled_pad.bin: ector a02a6131 crc a0872f31 adler b2b72c7f fletcher 5ac28e0e; 0400 bytes (0200 words)
Hashes of Extrems6/dspmixer.bin: ector a02a6131 crc a0872f31 adler b2b72c7f fletcher 5ac28e0e; 0400 bytes (0200 words)
Hashes of Extrems6/dspmixer_nopad.bin: ector 84c680a9 crc 1b1beb1d adler 2d952c7f fletcher 24058e0e; 03e6 bytes (01f3 words)
Hashes of Extrems/compiled.bin: ector 002e5e41 crc 5ba4fb19 adler 2dca2d5e fletcher 37a6ee8d; 03e8 bytes (01f4 words)
Hashes of Extrems/compiled_pad.bin: ector 2e5e4100 crc 8e2da39f adler 6ed62d5e fletcher 664dee8d; 0400 bytes (0200 words)
Hashes of Extrems/dspmixer.bin: ector 2e5e4100 crc 8e2da39f adler 6ed62d5e fletcher 664dee8d; 0400 bytes (0200 words)
Hashes of Extrems/dspmixer_nopad.bin: ector 002e5e41 crc 5ba4fb19 adler 2dca2d5e fletcher 37a6ee8d; 03e8 bytes (01f4 words)

This is used by libogc2 and libogc-rice.
This is used by libogc2 and libogc-rice.
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough.

@AdmiralCurtiss AdmiralCurtiss merged commit 2a56113 into dolphin-emu:master Jul 30, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants