add hw-accelerated SHA1 #10899
Merged
add hw-accelerated SHA1 #10899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuffle2
force-pushed
the
sha1
branch
8 times, most recently
from
2fa371b
to
978214c
Compare
dreamsyntax
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
on x64 (amd zen2): 3x speedup
on arm64 (qc "SQ1"): 2.5x speedup
SHA1 is relatively important for (wii) disc read performance and some other stuff. Might as well go fast if it's possible.
The unittests are mainly added because the arm64 implementation actually seems to trigger a msvc compiler bug (or i've made some bug which doesn't cause any compiler warning). The tests should help guard against something like that occurring in the future / on different compilers/versions.
this PR is ready to merge, but fwiw I've opened a msvc bug for the compiler issue here https://developercommunity.visualstudio.com/t/ARM64-bad-codegen-when-optimzing-intrins/10106733