Eliminate the magic constants in the switch statement in WII_IPC_HLE_Device_FileIO.cpp's Seek function. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -162,7 +163,7 @@ bool CWII_IPC_HLE_Device_FileIO::Seek(u32 _CommandAddress) | |||
|
|
|||
| switch (Mode) | |||
| { | |||
| case 0: | |||
| case SEEK_SET: | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…Device_FileIO.cpp's Seek function.
|
lgtm |
| @@ -181,7 +182,8 @@ bool CWII_IPC_HLE_Device_FileIO::Seek(u32 _CommandAddress) | |||
| } | |||
| break; | |||
| } | |||
| case 2: | |||
|
|
|||
| case WII_SEEK_END: | |||
| { | |||
| s32 wantedPos = fileSize+m_SeekPos; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Parlane
added a commit
that referenced
this pull request
Mar 2, 2014
Eliminate the magic constants in the switch statement in WII_IPC_HLE_Device_FileIO.cpp's Seek function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.