New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DolphinQt -- initial commit #1090
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for submodules! |
This adds the beginning of the DolphinQt user interface. It doesn't do anything useful yet and only builds via CMake.
|
rebased on master and reverted ENABLE_QT to default to OFF. |
|
has anyone actually tried/checked this PR? |
|
I'll check it now. |
|
This still builds and basically runs on OS X. There are a few issues:
Just saying. |
|
|
re:
|
|
+1 to merge |
|
IT BEGINS |
|
It would be nice if Qt wasn't so huge, that's the only thing wxwidgets that has going for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR was just to test buildbot configuration, and yay, it seems to work.
Now I've added the git submodule so anyone should be able to clone this branch and tell me if this is a good way to do it (you can also use a system-installed Qt SDK and set %QTDIR%).