Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt -- initial commit #1090

Merged
merged 3 commits into from Sep 17, 2014
Merged

DolphinQt -- initial commit #1090

merged 3 commits into from Sep 17, 2014

Conversation

shuffle2
Copy link
Contributor

This PR was just to test buildbot configuration, and yay, it seems to work.
Now I've added the git submodule so anyone should be able to clone this branch and tell me if this is a good way to do it (you can also use a system-installed Qt SDK and set %QTDIR%).

@waddlesplash
Copy link
Contributor

+1 for submodules!

@shuffle2 shuffle2 changed the title DolphinQt -- buildbot abuse edition DolphinQt -- initial commit Sep 15, 2014
waddlesplash and others added 3 commits September 15, 2014 15:06
This adds the beginning of the DolphinQt user interface. It doesn't
do anything useful yet and only builds via CMake.
@shuffle2
Copy link
Contributor Author

rebased on master and reverted ENABLE_QT to default to OFF.
Last call before this scary commit gets merged...

@shuffle2
Copy link
Contributor Author

has anyone actually tried/checked this PR?

@comex
Copy link
Contributor

comex commented Sep 17, 2014

I'll check it now.

@comex
Copy link
Contributor

comex commented Sep 17, 2014

This still builds and basically runs on OS X. There are a few issues:

  • No .app folder is generated, so the binary has to be run from a terminal.
  • The About dialog text is cut off unless you manually resize.
  • When run from a terminal, it spawns in the foreground rather than the background like every other app. Also, the menu does not display correctly until you switch to another app and back, which may simply be a consequence of the previous.

Just saying.

@waddlesplash
Copy link
Contributor

@comex

  • Not sure how to generate a .app folder, I'm not familiar with Mac. Can you handle that?
  • About dialog is my fault. Will investigate.
  • Also not sure about that, but none of the menus will open at all but the final ("About") one.

@shuffle2
Copy link
Contributor Author

re:

  • app folder: I think it's ok to skip this for now? On windows i purposefully prevent the last build stage from occuring such that the buildbot won't package it up. If you (@ anyone) do want to implement it, just take a look at the apple-related packaging tasks in https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/DolphinWX/CMakeLists.txt , should be mostly a copy-paste job.
  • about dialog: I think this can be fixed in a later PR (who knows, about dialog could be completely re-designed or something eventually, anyways).
  • spawn behavior: should be figured out, but I don't think the fix needs to go in this PR. Just need to know that it is fixable and will be fixed soon.

@comex
Copy link
Contributor

comex commented Sep 17, 2014

+1 to merge

shuffle2 added a commit that referenced this pull request Sep 17, 2014
@shuffle2 shuffle2 merged commit 978a855 into dolphin-emu:master Sep 17, 2014
@lioncash
Copy link
Member

IT BEGINS

@shuffle2 shuffle2 deleted the dolphin-qt branch September 17, 2014 05:29
@purpasmart96
Copy link

It would be nice if Qt wasn't so huge, that's the only thing wxwidgets that has going for it.

@leoetlino leoetlino modified the milestone: Qt Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants