Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netplay: use sha1 instead of md5 #10905

Merged
merged 2 commits into from Aug 22, 2022
Merged

netplay: use sha1 instead of md5 #10905

merged 2 commits into from Aug 22, 2022

Conversation

shuffle2
Copy link
Contributor

use the new, fast, sha1 for netplay "checksum" (i hate that that term is used here, lol)

iwubcode
iwubcode approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested. Code LGTM

@shuffle2
Copy link
Contributor Author

I think this PR is ready to merge :)

@shuffle2
Copy link
Contributor Author

Can someone merge this or indicate why it’s not being merged

AdmiralCurtiss
AdmiralCurtiss approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, although next time please re-sort the CMakeLists.txt in its own commit/PR...

@AdmiralCurtiss AdmiralCurtiss merged commit 1845a13 into dolphin-emu:master Aug 22, 2022
11 checks passed
@shuffle2 shuffle2 deleted the netplay-hash branch October 21, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pokechu22 Pokechu22 Pokechu22 left review comments

@AdmiralCurtiss AdmiralCurtiss AdmiralCurtiss approved these changes

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@shuffle2 @AdmiralCurtiss @Pokechu22 @iwubcode