SavePNG: make sure to finalize image file #10907

shuffle2 · 2022-07-28T04:06:06Z

😳forgot to put IEND in the png

JosJuice · 2022-07-28T09:45:55Z

Source/Core/Common/Image.cpp

@@ -95,7 +95,8 @@ bool SavePNG(const std::string& path, const u8* input, ImageByteFormat format, u
  if (spng_set_ihdr(ctx.get(), &ihdr))
    return false;

-  if (spng_encode_image(ctx.get(), nullptr, 0, SPNG_FMT_PNG, SPNG_ENCODE_PROGRESSIVE))
+  if (spng_encode_image(ctx.get(), nullptr, 0, SPNG_FMT_PNG,
+                        SPNG_ENCODE_PROGRESSIVE | SPNG_ENCODE_FINALIZE))
    return false;


Please add braces.

dvessel · 2022-07-28T12:52:21Z

This fixes the errors. Thanks!

This was referenced Jul 28, 2022

replace libpng with libspng #10889

Merged

libpng can’t read files. randy408/libspng#226

Closed

JosJuice reviewed Jul 28, 2022

View reviewed changes

SavePNG: make sure to finalize image file

25462f4

shuffle2 force-pushed the pngend branch from a30a67a to 25462f4 Compare July 28, 2022 17:12

AdmiralCurtiss merged commit 000c9c7 into dolphin-emu:master Jul 28, 2022
11 checks passed

shuffle2 deleted the pngend branch July 31, 2022 17:13

SavePNG: make sure to finalize image file #10907

SavePNG: make sure to finalize image file #10907

shuffle2 commented Jul 28, 2022

JosJuice Jul 28, 2022

dvessel commented Jul 28, 2022

SavePNG: make sure to finalize image file #10907

SavePNG: make sure to finalize image file #10907

Conversation

shuffle2 commented Jul 28, 2022

JosJuice Jul 28, 2022

Choose a reason for hiding this comment

dvessel commented Jul 28, 2022