Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msbuild: set PreferredToolArchitecture based on host OS arch #10912

Merged
merged 1 commit into from
Jul 31, 2022
Merged

msbuild: set PreferredToolArchitecture based on host OS arch #10912

merged 1 commit into from
Jul 31, 2022

Conversation

shuffle2
Copy link
Contributor

@shuffle2 shuffle2 commented Jul 28, 2022

allows using arm64-native toolchain on arm64.

Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

@shuffle2
Copy link
Contributor Author

shuffle2 commented Jul 28, 2022

hm, it seems that VS on the buildbot somehow installed into the Program Files (x86) directory altho it is x64. I guess that means some method VS/msbuild uses to check host architecture is bugged in some cases or something...

(not sure that's the root of the issue, will have to login to builder and see what's up; can't seem to access it atm)

ah, the buildbot thing is because i've installed only the build tools and not full VS - and for whatever reason it chooses x86 program files. I've fixed the issue a different way

@shuffle2 shuffle2 changed the title msbuild: dont explicitly set PreferredToolArchitecture msbuild: set PreferredToolArchitecture based on host OS arch Jul 28, 2022
@Tilka Tilka merged commit 2c754db into dolphin-emu:master Jul 31, 2022
@shuffle2 shuffle2 deleted the msbuild-arch branch July 31, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants