msvc: fix issues with vs 17.3 #10913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuffle2
commented
Jul 28, 2022
iwubcode
reviewed
Jul 29, 2022
|
while this is currently needed to build on vs preview, i'm not sure if the |
|
Simple repro case: https://godbolt.org/z/YEGEr4zGn I don't see why a default parameter would change anything as far as the standard is concerned. Interestingly, MSVC doesn't complain when using |
|
Thanks, I'm just going to report it as a msvc bug and see what they say :-) |
|
The std::unique_ptr change is expected c++23 behavior: https://github.com/microsoft/STL/pull/2582/files |
std::unique_ptr can't/won't call deleter on incomplete type generated warning on vs 17.3.0 preview 5.0
lioncash
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.