BBA - Rename Built In BBA to BBA (HLE) #10914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Jul 28, 2022
JosJuice
reviewed
Jul 28, 2022
|
I'm not sure this is 100% perfect, but it is a definite improvement. LGTM. |
|
I find odd that we specify HLE/LLE in parentheses when we don't for DSP. What about just changing Regardless, LGTM. |
JosJuice
reviewed
Jul 29, 2022
| _trans("Triforce AM Baseboard"), | ||
| _trans("USB Gecko"), | ||
| _trans("GCI Folder"), | ||
| _trans("Advance Game Port"), | ||
| _trans("Broadband Adapter (XLink Kai)"), | ||
| _trans("Broadband Adapter (LLE XLink Kai)"), | ||
| _trans("Broadband Adapter (tapserver)"), |
There was a problem hiding this comment.
Could we change this to Broadband Adapter (LLE tapserver), so it matches the other ones? LGTM after that.
Or if you go with sepalani's suggestion, skip my suggestion.
All of our BBA options are technically built in, so it made the BBA Built In option kind of confusing as to what it did. So rename it to BBA HLE to make it more clear what it is doing and why it doesn't need a TAP.
JMC47
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Broadband Adapter Option names were a bit confusing before, so let's clean them up.