BBA/BuiltIn: Ensure UDP ports are open #10918
Merged
+15
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't crash on Android like the other one. Windows cannot see a real console period, much like master. Android can connect to console or other Dolphin instances. The noted deadlock from the other pull request happens if both try to connect at once to a console. |
iwubcode
approved these changes
Jul 29, 2022
|
Rebased on latest master, whitespaces should be hidden to remove some diff noises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR ensures that the required UDP ports are open.
Ready to be reviewed & tested.