Android: Use AfterDirectoryInitializationRunner on FAB press #10919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, if the user finishes selecting a directory before directory initialization finishes, MainPresenter.onDirectorySelected will segfault when trying to read the MAIN_RECURSIVE_ISO_PATHS setting. An alternative would be to use AfterDirectoryInitializationRunner after the user selects the directory instead of before, but it might be confusing for the user to deal with the usage statistics prompt when they were expecting to add a folder.
|
Fixes the crash where I was speedrunning setting up folders to test after installing new PRs. |
lioncash
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Without this, if the user finishes selecting a directory before directory initialization finishes,
MainPresenter.onDirectorySelectedwill segfault when trying to read theMAIN_RECURSIVE_ISO_PATHSsetting.An alternative would be to use
AfterDirectoryInitializationRunnerafter the user selects the directory instead of before, but it might be confusing for the user to deal with the usage statistics prompt when they were expecting to add a folder.