New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBA/BuiltIn: Add SSDP multicast support #10920
Conversation
|
This PR causes a crash on android for my device (Pixel 3a) but apparently no one else has the problem. |
|
After some testing, here's what's worth mentioning for Windows users:
|
|
For reference, so that it isn't lost: Here is a log from JMC reproducing the crash. No symbols for the native code, unfortunately. https://pastebin.com/BFpmnxby |
|
Needs a rebase |
|
@JMC47 |
|
I somehow missed this comment. My bad. Testing now |
|
@sepalani this works and does not crash on Android. |
e0e12b9
to
ce928fd
Compare
ce928fd
to
7202cf2
Compare
|
@iwubcode This PR was rebased to use |
|
Is this all done now? I'd like to get the BBA stuff squared away before the Progress Report and Beta build. |
This PR implements the SSDP multicast support properly. It fixes one issue I had where my Windows host, its Linux VM and my smartphone couldn't see each other joining/leaving the LAN consistently. This method also seems firewall friendly, I don't see packets being dropped anymore on Wireshark.
The UDP port not opening issue isn't fixed in this PR. If the Windows discovery service is enabled, the VM and its hosts can't see each other consistently (shouldn't matter as I don't expect many people to use Dolphin in a VM to play LANs/online).
Ready to be reviewed & tested.
This change is