PPCSymbolDB: Fix getting symbol for the last function #10924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
It took me a minute to understand why this works for the very first address: It hits the |
|
I think this would be clearer as: |
|
That has the exact same bug as the old code; |
|
Aaah yup you're right, lower_bound is confusing me. I guess this is fine as-is then. |
sepalani
approved these changes
Jul 30, 2022
| if (it != m_functions.end()) | ||
| { | ||
| // If the address is exactly the start address of a symbol, we're done. | ||
| if (it->second.address == addr) |
There was a problem hiding this comment.
This if statement can be combined with the above one: it != m_functions.end() && it->second.address == addr. Feel free to ignore this comment.
There was a problem hiding this comment.
I think it's a bit more readable this way since the one below needs to be two separate statements, so having this one be two makes it a bit more consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It's easiest to illustrate the bug that I fixed with an example from System Menu 4.3U (the functions I'm using here are arbitrary, chosen just because they're short):
(In the debugger, to set the address, use the top-left text field labeled search address, and to add a function, right-click the specified address and select "add function" (2nd entry in the bottom group, below "run to here").)
This is an issue I ran into on #10923, and doesn't just affect "add function".