CMake: Actually use the include directories specified by dependencies #10936
+31
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on macOS 10.15.7 Catalina. Is this old enough? ;) |
|
Our oldest supported OS is Mojave. |
|
find_package(LibLZMA) only defines a target as of CMake version 3.14 (according to the documentation anyway) but our minimum is 3.13. |
TellowKrinkle
force-pushed
the
FixIncludeDirs
branch
from
a9f6aee
to
5e04053
Compare
TellowKrinkle
force-pushed
the
FixIncludeDirs
branch
from
5e04053
to
1bc133f
Compare
Should be fixed Tested on 10.14.6, launches fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Homebrew does not install header-less versions of zstd. You just need to use the include directory returned by pkg-config to find them.
For LZMA, macOS does include a headerless dylib, but FindLibLZMA searches for the header and marks LZMA as not found unless the header is also found. Once again, the issue was us ignoring the required include directories.
Note: Before merging, we should make sure buildbot builds still run on older macOSes, since this could affect what system libraries get used, and Homebrew libs are not compiled with backwards compatibility enabled