Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameSettings: Set MissingColorValue for Lego Indiana Jones 1 #10937

Conversation

Pokechu22
Copy link
Contributor

See https://bugs.dolphin-emu.org/issues/12987. The alpha value of 0x82 was determined by disabling all objects other than the highlight (and object 0 which clears the screen) in the hardware fifoplayer (image), and then checking the output color (which is 0xAAAAAB or 0xABABAB depending on the pixel). 0x82 gives the closest result (though it's not a perfect match for every pixel, likely due to other slight inaccuracies with lighting). After that I compared across all of the provided fifologs, and things seem to be a generally good match (some differences are a value of 3, but I think part of this is related to bloom and lighting; in any case it looks close enough and isn't broken anymore).

Like with the debug cube fix (#9532), this is a hack.

Test Dolphin old Real hardware Dolphin new
Hub 1_y0_x0 1_y0_x0 1_y0_x0
1-5 1_y0_x0 lego_indiana_jones_puzzle_1-5 1_y0_x0
2-1 1_y0_x0 lego_indiana_jones_puzzle_2-1 1_y0_x0
2-5 1_y0_x0 lego_indiana_jones_puzzle_2-5 1_y0_x0
3-1a 1_y0_x0 lego_indiana_jones_puzzle_3_1a 1_y0_x0
3-1b 2_y0_x0 2_y0_x0 1_y0_x0
3-1c 1_y0_x0 lego_indiana_jones_puzzle_3_1c 1_y0_x0
3-5 1_y0_x0 lego_indiana_jones_puzzle_3_5 1_y0_x0

(The other texture glitchyness in some of these is a separate issue and does not happen ingame.)

@lioncash lioncash merged commit f3c85ca into dolphin-emu:master Aug 3, 2022
11 checks passed
Pokechu22 added a commit to Pokechu22/dolphin that referenced this pull request Oct 24, 2022
In 3465b2a (dolphin-emu#10937) I incorrectly put it under [Video_Settings] instead of [Video_Hacks], so it didn't work. https://bugs.dolphin-emu.org/issues/12987 should now properly be fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants