GameSettings: Set MissingColorValue for Lego Indiana Jones 1 #10937
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See https://bugs.dolphin-emu.org/issues/12987. The alpha value of 0x82 was determined by disabling all objects other than the highlight (and object 0 which clears the screen) in the hardware fifoplayer (image), and then checking the output color (which is 0xAAAAAB or 0xABABAB depending on the pixel). 0x82 gives the closest result (though it's not a perfect match for every pixel, likely due to other slight inaccuracies with lighting). After that I compared across all of the provided fifologs, and things seem to be a generally good match (some differences are a value of 3, but I think part of this is related to bloom and lighting; in any case it looks close enough and isn't broken anymore).
Like with the debug cube fix (#9532), this is a hack.
(The other texture glitchyness in some of these is a separate issue and does not happen ingame.)