Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Don't set the signingConfig if keystore property isn't set #10938

Merged
merged 1 commit into from Aug 10, 2022

Conversation

Pokechu22
Copy link
Contributor

If the property isn't set, we don't initialize the release config, so we shouldn't use it. This fixes building issues for me.

signingConfigs {
release {
if (project.hasProperty('keystore')) {
storeFile file(project.property('keystore'))
storePassword project.property('storepass')
keyAlias project.property('keyalias')
keyPassword project.property('keypass')
}
}
}

Before, I was getting this message when running gradlew assemble:

> Task :app:packageRelease FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:packageRelease'.
> A failure occurred while executing com.android.build.gradle.tasks.PackageAndroidArtifact$IncrementalSplitterRunnable
   > SigningConfig "release" is missing required property "storeFile".

I haven't tested this change in a setup which has an actual signing config (and don't really want to set one up myself).

If the property isn't set, we don't initialize the release config, so we shouldn't use it. This fixes building issues for me.
@JosJuice JosJuice merged commit 6fbc1cb into dolphin-emu:master Aug 10, 2022
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants