New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Add Androidx splash screen to wait for directory initialization #10948
Conversation
|
Please ensure that this works under the following situations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about the two points above on IRC yesterday. It seems like this PR is not aiming to add a splash screen on Android TV for now, and the PR has now been amended to address the situation of asking for permission.
There was a new situation I thought of yesterday that I believe this PR currently doesn't handle correctly: The situation where Android evicts the app from memory and the user then returns to the app later, bypassing the splash screen activity.
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/SplashScreenActivity.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/SplashScreenActivity.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainActivity.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/StartupHandler.java
Outdated
Show resolved
Hide resolved
|
The splash screen now appears the same across all android versions. Turns out you could make the splash screen appear under API 31 by using windowSplashScreenAnimatedIcon and not android:windowSplashScreenAnimatedIcon... But now I'm pretty happy with everything involved with the splash screen. Let me know if there's anything else I should look out for @JosJuice or we could go ahead with a merge. |
|
Oh, I also just discovered that the splash screen will not appear on devices below API 23. I'm not surprised... but I'm still ok with that. |
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainActivity.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainActivity.java
Outdated
Show resolved
Hide resolved
|
My remaining comments:
|
This shows a blank splash screen while Dolphin initializes its configuration system.
Light

Dark
