WiiSave: protect against a stack buffer overflow #10954
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
approved these changes
Aug 6, 2022
|
fwiw i heard back from the user that this did actually fix their problem (altho i guess dolphin dropped some corrupted save) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
this appears to have caused a crash for a user, but I haven't gotten confirmation this actually fixes their crash (I think they may have nuked everything and started fresh)
i tend to think their actual corruption happened before this, but this check should be there anyway, I think.
related: it's gross to have this huge thing on the stack