Address c++20 TODO comments #10956
Merged
Address c++20 TODO comments #10956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentomologist
commented
Aug 6, 2022
Dentomologist
force-pushed
the
address_cpp20_todo_comments
branch
from
3119c3f
to
2c8f479
Compare
dir_path is used by PanicAlertFormatT, which prior to PR 10209 used a lambda. Before c++20, referring to structured bindings in lambda captures was forbidden. The problem is now doubly fixed, so put the structured binding back in.
Dentomologist
force-pushed
the
address_cpp20_todo_comments
branch
from
2c8f479
to
02cd4ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR used to replace the workaround function FillWithFallbacks(table) in Jit64_Tables.cpp with table.fill(...) now that array.fill is constexpr, but the android and freebsd builders don't support constexpr fill. It also used to add make_unique_for_overwrite in a couple places, but most of the builders don't support that.