Interpreter: Fix rounding edge case in frsp #10959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the Dolphin bug mentioned in dolphin-emu/hwtests#45. Because this doesn't fix any observed behavior in games (no, 1080° Avalanche isn't affected), I haven't implemented this in the JITs, so as to not cause unnecessary performance degradations.
JosJuice
added a commit
to JosJuice/hwtests
that referenced
this pull request
Aug 6, 2022
I wrote these two tests because I wanted to test if the behavior I implemented in dolphin-emu/dolphin#10959 should affect the results of arithmetic operations in addition to frsp. It turned out that Dolphin was already correctly emulating these two tests (I frankly don't understand how in the float case), but I figured I would submit the tests regardless. If nothing else, it's good for documenting what the real hardware is doing.
lioncash
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes the Dolphin bug mentioned in dolphin-emu/hwtests#45.
Because this doesn't fix any observed behavior in games (no, 1080° Avalanche isn't affected), I haven't implemented this in the JITs, so as to not cause unnecessary performance degradations.