ResourcePack: dont scan for individual files #10960
Merged
+77
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuffle2
force-pushed
the
mz
branch
2 times, most recently
from
72ab94b
to
fbe58ae
Compare
iwubcode
reviewed
Aug 6, 2022
iwubcode
reviewed
Aug 6, 2022
iwubcode
reviewed
Aug 6, 2022
iwubcode
reviewed
Aug 6, 2022
walking the zip prevents minizip from re-reading the same data repeatedly from the actual backing filesystem. also improves most usages of minizip to allow for >4GB, files altho we probably don't need it
|
Could you split the >4GB file change into a separate commit from the file scanning change? I'm not familiar with the resource pack code (or minizip as a library) so it's a bit hard to tell what's part of what. |
|
I think this PR is ready to merge, and I'm not going to spend time to split the commits for review purposes |
|
Seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
walking the zip prevents minizip from re-reading the same
data repeatedly from the actual backing filesystem.
also improves most usages of minizip to allow for >4GB,
files altho we probably don't need it
drops time to "install" https://forums.dolphin-emu.org/Thread-sonic-adventure-2-battle-hd-project-v2-3-june-21-2019 from 9:30 (MINUTES) to 25 seconds (which is still pretty slow imo).
fwiw i tested also with the buffered minizip layer, and there's no speedup. likely because we just read the entire file once. there might be further speedup by decoupling the read + write operations (so it's not serialized), but meh.