back out using std::chrono for timezone stuff #10963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
Aug 7, 2022
| return seconds.get_local_time().time_since_epoch().count(); | ||
| #else | ||
| // TODO Would really, really like to use std::chrono here, but Windows did not support | ||
| // std::chrono::current_zone() until 19H1, and other compilers don't even provide support for |
iwubcode
approved these changes
Aug 7, 2022
|
Dear developers, I am the author of that bug report. Recently I was forced to update my LTSC 1809 installation to the LTSC 21H2 version in order to keep using WhatsApp for desktop for working purposes, so now you could reimplement this feature if you wanted. Also, I checked my System32 folder and this version of Windows LTSC does come with the icu.dll file. So I am at your disposal if you want me to test this feature again in this version. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
People really like running old OS
fixes https://bugs.dolphin-emu.org/issues/13007