Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS/FS: Skip writing FST if SetMetadata() changes nothing. #10972

Merged
merged 1 commit into from Aug 11, 2022
Merged

IOS/FS: Skip writing FST if SetMetadata() changes nothing. #10972

merged 1 commit into from Aug 11, 2022

Conversation

AdmiralCurtiss
Copy link
Contributor

This accounts for a shocking amount of writes to fst.bin, in particular during dolphin startup.

iwubcode
iwubcode approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested. LGTM

leoetlino
leoetlino approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@leoetlino leoetlino merged commit be33e10 into dolphin-emu:master Aug 11, 2022
@AdmiralCurtiss AdmiralCurtiss deleted the ios-fs-metadata-nop branch August 11, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino approved these changes

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@AdmiralCurtiss @leoetlino @iwubcode