Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes in dual core mode on a PI_FIFO_RESET #10989

Merged
merged 1 commit into from Aug 18, 2022
Merged

Fix crashes in dual core mode on a PI_FIFO_RESET #10989

merged 1 commit into from Aug 18, 2022
+23 −1

Conversation

CasualPokePlayer
Copy link
Contributor

Fixes https://bugs.dolphin-emu.org/issues/13001

Not sure entirely if this is all proper, but it should work fine?

Pokechu22
Pokechu22 approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a bit concerned about the various 0xff unknown opcodes I've gotten in TTYD in dual core, since PI_FIFO_RESET was supposed to eliminate those entirely (see #10454 for an explanation of where those came from). But this is still an improvement, so it's worth merging and those can be investigated further later.

@JMC47 JMC47 merged commit 498c06b into dolphin-emu:master Aug 18, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pokechu22 Pokechu22 Pokechu22 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@CasualPokePlayer @Pokechu22 @JMC47