Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt: defer writing gamelist cache until EndRefresh #10993

Merged
merged 1 commit into from Aug 20, 2022
Merged

qt: defer writing gamelist cache until EndRefresh #10993

merged 1 commit into from Aug 20, 2022

Conversation

shuffle2
Copy link
Contributor

when refreshing gamelist, GameFileCache::Save took up 70% of entire runtime, and populating the list was slow.

with this change, GameFileCache::Save takes up near zero of overall runtime, and list updates quickly.

iwubcode
iwubcode approved these changes Aug 20, 2022
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM

@JosJuice JosJuice merged commit 924a4ee into dolphin-emu:master Aug 20, 2022
11 checks passed
@shuffle2 shuffle2 deleted the gamelist-cache branch October 21, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@shuffle2 @iwubcode @JosJuice