Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of HAS_STD_FILESYSTEM #10994

Merged
merged 1 commit into from Jan 24, 2023
Merged

get rid of HAS_STD_FILESYSTEM #10994

merged 1 commit into from Jan 24, 2023

Conversation

shuffle2
Copy link
Contributor

just use std::filesystem

let's see if we can finally get rid of it...

@shuffle2
Copy link
Contributor Author

shuffle2 commented Aug 20, 2022

lol

at this point i'm just going to say it's blocked until we update minimum requirements to actually support c++20.

@shuffle2
Copy link
Contributor Author

shuffle2 commented Jan 9, 2023

OK, it compiles now - so ready for review

@JosJuice
Copy link
Member

You could replace this too:

static std::string MakeAbsolute(const std::string& directory, const std::string& path)
{
#ifdef _WIN32
return PathToString(StringToPath(directory) / StringToPath(path));
#else
if (StringBeginsWith(path, "/"))
return path;
return directory + "/" + path;
#endif
}

@shuffle2
Copy link
Contributor Author

You could replace this too:

static std::string MakeAbsolute(const std::string& directory, const std::string& path)
{
#ifdef _WIN32
return PathToString(StringToPath(directory) / StringToPath(path));
#else
if (StringBeginsWith(path, "/"))
return path;
return directory + "/" + path;
#endif
}

should i just merge this PR and #11426 ? wasn't sure if it was 'too much'

@JosJuice
Copy link
Member

I think it makes sense to keep them separate.

just use std::filesystem
@delroth delroth merged commit caca662 into dolphin-emu:master Jan 24, 2023
11 checks passed
Wowfunhappy added a commit to Wowfunhappy/dolphin that referenced this pull request Jan 25, 2023
This reverts commit caca662, reversing
changes made to d4d6f3d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants