Android: Use vector icon and enable monochrome icon #11000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm replacing the raster icon with a vector one so the icon can continue to look good at greater resolutions. This also adds the silhouette layer of the dolphin icon to be used as the "monochrome" themed icon available in Android 13.
Themed examples (changed based on wallpaper and dark/light theme) -
Existing icon looks exactly the same. The ic_dolphin tweaks are because I had to center it based on what @MayImilae and I discussed in #10533.
NOTE - These themed icons are OPT-IN and availability will vary based on launcher support. Refer to this link for more info.