Edit error message #11007
Merged
Edit error message #11007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit error message to be less sarcastic. I doubt many users appreciate this when Dolphin has just crashed.
|
Instead of just removing it, why not just replace it with something lighter, like "whoops", "oops", etc? |
|
I don't see how that benefits anyone and as far as I know none of the other error messages in Dolphin are phrased like that. |
AdmiralCurtiss
approved these changes
Aug 23, 2022
|
LGTM, but wait with merging this until after the next beta release so that the translation for this string doesn't get reset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Edit error message to be less sarcastic. I doubt many users appreciate this when Dolphin has just crashed on them.