Android: Fix reading custom covers with SAF #11017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
saf-custom-cover
branch
2 times, most recently
from
912b2d0
to
4c15ae1
Compare
If GameFile.getCustomCoverPath returns a mangled URI, we need to unmangle it before passing it to Picasso, since Picasso has no concept of Dolphin's mangled URIs.
JosJuice
force-pushed
the
saf-custom-cover
branch
from
4c15ae1
to
40d6d61
Compare
lioncash
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If
GameFile.getCustomCoverPathreturns a mangled URI, we need to unmangle it before passing it to Picasso, since Picasso has no concept of Dolphin's mangled URIs.