Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updater error messages #11018

Merged

Conversation

Dentomologist
Copy link
Contributor

@Dentomologist Dentomologist commented Aug 28, 2022

Fixes error reporting during update checks and adds error messages for several things that can go wrong while triggering an update.

On master, any error during an update check either incorrectly reports Dolphin is up to date (for manual checks) or is just logged (for automatic checks). This PR reports the correct errors, and also shows a message box for all manual check results and certain automatic results to make issues more visible.

Event details:

  • Up to date: (Unchanged from master, only shown for manual checks):
    "You are running the latest version available on this update track."
  • Check request failed: (Error, manual):
    "Unable to contact update server."
  • Invalid JSON in server response: (error, manual and automatic):
    "Invalid JSON received from auto-update service: {error description}."
  • Updater copy failed: (error, manual and automatic)
    "Unable to create updater copy."
  • Failed to set permissions: (error, manual and automatic)
    "Unable to set permissions on updater copy."
  • Updater launch failed: (error, manual and automatic)
    "Could not start updater process: {error description}."

Discussion items:

  • Wording of error messages.
  • Which errors during automatic checks should generate an alert.

@Pokechu22
Copy link
Contributor

Would SuccessAlertFmt/CriticalAlertFmt be usable here? That system is already UI frontend agnostic.

@Dentomologist
Copy link
Contributor Author

Pokechu22: Thank you, I didn't know about those.

@shuffle2
Copy link
Contributor

shuffle2 commented Nov 2, 2022

lgtm

@AdmiralCurtiss
Copy link
Contributor

There's an unused bool m_update_available in the Updater header now, from what I can tell.

Otherwise yeah seems fine.

@AdmiralCurtiss AdmiralCurtiss merged commit b6503d7 into dolphin-emu:master Nov 15, 2022
11 checks passed
@Dentomologist Dentomologist deleted the add_updater_error_messages branch February 17, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants