Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme links #11019

Merged
merged 1 commit into from Sep 23, 2022
Merged

Update Readme links #11019

merged 1 commit into from Sep 23, 2022

Conversation

PEmu2
Copy link
Contributor

@PEmu2 PEmu2 commented Aug 29, 2022

Fix Transifex link and update formatting.

Fix Transifex link and update formatting.
@Zopolis4
Copy link
Contributor

Do we need the trailing slashes? To my knowledge not having a trailing slash is best practice, although I acknowledge that in this age it is mostly a matter of preference.

@Docteh
Copy link

Docteh commented Aug 30, 2022

Personally the determination I'd use for that is: does the website fight you? Without a trailing slash you get redirected to have the trailing slash.

[docteh@haus ~]$ curl -v -s https://explore.transifex.com/delroth/dolphin-emu 1> /dev/null
<snip>
> GET /delroth/dolphin-emu HTTP/2
> Host: explore.transifex.com
> user-agent: curl/7.84.0
> accept: */*
>
{ [5 bytes data]
* Connection state changed (MAX_CONCURRENT_STREAMS == 128)!
} [5 bytes data]
< HTTP/2 308
< date: Tue, 30 Aug 2022 10:09:20 GMT
< location: /delroth/dolphin-emu/
< refresh: 0;url=/delroth/dolphin-emu/
<
{ [21 bytes data]
* Connection #0 to host explore.transifex.com left intact
[docteh@haus ~]$ curl -v -s https://explore.transifex.com/delroth/dolphin-emu/ 1> /dev/null
<snip>
> GET /delroth/dolphin-emu/ HTTP/2
> Host: explore.transifex.com
> user-agent: curl/7.84.0
> accept: */*
>
{ [5 bytes data]
* Connection state changed (MAX_CONCURRENT_STREAMS == 128)!
} [5 bytes data]
< HTTP/2 200
< date: Tue, 30 Aug 2022 10:12:03 GMT
< content-type: text/html; charset=utf-8
< x-powered-by: Next.js
< cache-control: private, no-cache, no-store, max-age=0, must-revalidate
< vary: Accept-Encoding
<
{ [16224 bytes data]
* Connection #0 to host explore.transifex.com left intact

Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@AdmiralCurtiss AdmiralCurtiss merged commit b314e2a into dolphin-emu:master Sep 23, 2022
1 check failed
@PEmu2 PEmu2 deleted the readme branch December 22, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants