HW: Move DVD variables to Core::System. #11029
Merged
+547
−394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Sep 3, 2022
| CoreTiming::EventType* m_finish_executing_command; | ||
| CoreTiming::EventType* m_auto_change_disc; | ||
| CoreTiming::EventType* m_eject_disc; | ||
| CoreTiming::EventType* m_insert_disc; |
There was a problem hiding this comment.
If I recall correctly, the Dolphin style is to not include the m_ prefix for public struct members.
There was a problem hiding this comment.
It doesn't actually explicitly say this one way or another, only that class member variables should have m_ prefixes, and a struct and a class is kinda the same thing as far as C++ is concerned... but yeah I can change that, I don't really care either way.
There was a problem hiding this comment.
Yeah, I couldn't find it mentioned in Contributing.md. It's more of an unwritten convention.
AdmiralCurtiss
force-pushed
the
global-state-dvd
branch
from
1e91593
to
2d45ce5
Compare
lioncash
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.