Debugger MemoryWidget: Create mini-menu at top of sidebar. #11039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I like this, but you're right that the address used for Set value from file might be unclear. Maybe rename it to something like... I dunno, 'Load file to current address'? |
TryTwo
force-pushed
the
PR_MemoryWidget_MiniMenu
branch
from
f2595e5
to
d988a48
Compare
…buttons and "set value from file" to the menu.
TryTwo
force-pushed
the
PR_MemoryWidget_MiniMenu
branch
from
d988a48
to
50db8f3
Compare
AdmiralCurtiss
approved these changes
Sep 9, 2022
|
Yeah, it's a good place for future options too, like if I add auto-updating options to the table.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Move dump buttons and "set value from file" to the menu.
Trying to put lesser used buttons in a more logical place and free up room for possibly other items later.