Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Change top app bar color on scroll #11053

Merged
merged 1 commit into from Sep 14, 2022

Conversation

t895
Copy link
Contributor

@t895 t895 commented Sep 11, 2022

To create more visual separation between list contents and the top app bar, the color will slightly change when collapsing the top app bar on the settings activity. Additionally this fixes visual bugs where an incorrect color would flash when expanding the collapsed toolbar and on some API levels top app bars would have a shadow appear underneath which is now removed.

Every activity with a collapsing top app bar will now tint on scroll

Before -
before

After -
after

Other Themes

Green
image

Pink
image

@MayImilae
Copy link
Contributor

That's pretty nice. What determines the top bar colour?

@t895
Copy link
Contributor Author

t895 commented Sep 12, 2022

We have a color defined on each theme with light/dark variants called colorSurfaceVariant

@JosJuice JosJuice merged commit 7eece76 into dolphin-emu:master Sep 14, 2022
11 checks passed
@t895 t895 deleted the top-app-bar branch January 1, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants