windows: distribute vcredist loose files #11063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work fine. For CMake I'd just look at what we're doing for Qt DLLs and not use their functions? |
The installer needs other maintenence, but this at least removes some cruft
|
LGTM. Feel free to merge if you're done with it, otherwise I can give it another look later. |
|
yea it's done but i dont have merge privs :) (you can merge it) |
|
Are those the only files required? Granted it was years ago since I last tried this (around VS 2017 time) but I remember Dolphin requiring a bunch of |
|
apiset dlls are unrelated to vc++ redist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.