Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netplay: Rename variable names in NetSettings to match style guide. #11071

Merged
merged 2 commits into from Sep 19, 2022
Merged

Netplay: Rename variable names in NetSettings to match style guide. #11071

merged 2 commits into from Sep 19, 2022

Conversation

AdmiralCurtiss
Copy link
Contributor

Let's just fix this before we start discussing... (see #11047 (comment))

iwubcode
iwubcode approved these changes Sep 18, 2022
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize structs behaved differently, that's good to know! Anyway, eyeball'd this, it LGTM.

@JosJuice JosJuice merged commit 720b3f5 into dolphin-emu:master Sep 19, 2022
11 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the netplay-settings-style branch September 19, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@AdmiralCurtiss @iwubcode @JosJuice