New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metal as backend option with Vulkan Disabled #11073
Conversation
|
Thanks, it’s working on my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested, but looks good to me.
|
Also, does Vulkan needs to take precedence on macOS now that we have a native Metal backend? |
|
I'm pretty sure that OpenGL needs to not be the default on macOS still, but I don't know whether it'd be better to have Vulkan or Metal be the default. |
|
I was talking about making Metal the default on macOS. While MoltenVK is great, it just seems logical to me to default to the native Metal API now that we have a backend for it... |
|
I believe the decision in the original Metal PR was to leave Vulkan as default until the Metal backend matures: #10754 (comment) For what it's worth there's still an unmerged PR of Metal backend fixes in #11028. |
+1 Dolphin requires macOS Mojave or later, which in turn requires a Metal-compatible video adapter. Yes, there are ways to make an unsupported Mac run later macOS versions (I‘m currently running Monterey via OCLP on my Late 2013 iMac and it works like a charm), but at least the officially supported Macs should run the Metal and Vulkan backends out of the box. Users running patched macOS versions should know what they are doing and switch to OpenGL if their video card doesn't support Metal.
I‘d leave it at Vulkan for the time being, since the backend has been around for some time to mature. Also #10754 (comment). |
|
I almost considered making metal take precedence, but then I remembered that it was decided to keep vulkan as default for now. |
Current implementation requires vulkan to be enabled to have the metal backend as an option.