Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metal as backend option with Vulkan Disabled #11073

Merged
merged 2 commits into from Sep 23, 2022

Conversation

Hibyehello
Copy link
Contributor

Current implementation requires vulkan to be enabled to have the metal backend as an option.

@Hibyehello Hibyehello changed the title Add Metal as backend with Vulkan Disabled Add Metal as backend option with Vulkan Disabled Sep 19, 2022
@dvessel
Copy link
Contributor

dvessel commented Sep 19, 2022

Thanks, it’s working on my end.

Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but looks good to me.

@mbc07
Copy link
Contributor

mbc07 commented Sep 20, 2022

Also, does Vulkan needs to take precedence on macOS now that we have a native Metal backend?

@Pokechu22
Copy link
Contributor

I'm pretty sure that OpenGL needs to not be the default on macOS still, but I don't know whether it'd be better to have Vulkan or Metal be the default.

@mbc07
Copy link
Contributor

mbc07 commented Sep 20, 2022

I was talking about making Metal the default on macOS. While MoltenVK is great, it just seems logical to me to default to the native Metal API now that we have a backend for it...

@PEmu2
Copy link
Contributor

PEmu2 commented Sep 20, 2022

I believe the decision in the original Metal PR was to leave Vulkan as default until the Metal backend matures: #10754 (comment)

For what it's worth there's still an unmerged PR of Metal backend fixes in #11028.

@pizuz
Copy link

pizuz commented Sep 20, 2022

I'm pretty sure that OpenGL needs to not be the default on macOS still

+1

Dolphin requires macOS Mojave or later, which in turn requires a Metal-compatible video adapter.

Yes, there are ways to make an unsupported Mac run later macOS versions (I‘m currently running Monterey via OCLP on my Late 2013 iMac and it works like a charm), but at least the officially supported Macs should run the Metal and Vulkan backends out of the box. Users running patched macOS versions should know what they are doing and switch to OpenGL if their video card doesn't support Metal.

but I don't know whether it'd be better to have Vulkan or Metal be the default.

I‘d leave it at Vulkan for the time being, since the backend has been around for some time to mature. Also #10754 (comment).

@Hibyehello
Copy link
Contributor Author

I almost considered making metal take precedence, but then I remembered that it was decided to keep vulkan as default for now.

@AdmiralCurtiss AdmiralCurtiss merged commit b7855a3 into dolphin-emu:master Sep 23, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants