New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt/Controllers: Refresh GUI on settings change. #11075
Qt/Controllers: Refresh GUI on settings change. #11075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested but code looks good. Nice work!
|
Ok, did a bit of testing to complete this. Not noticing any regressions or other issues. |
|
Alright then. |
|
Supposedly this causes a crash: https://bugs.dolphin-emu.org/issues/13141 |
|
@AdmiralCurtiss do you know if this PR caused the threading issues seen in that issue? Or does this PR just happen to make it more obvious? If the former, maybe this PR should be reverted (and |
|
note however, that the Config stuff seems to be broken even without threading issues: since Add/Remove can be called recursively, you either wind up with iterators into |
|
I'll have to look at it in detail, but yeah the entire system is a bit sketchy... |
(without triggering signals)
Prep work for allowing opening the Controller settings mid-Netplay without everything breaking. See #11070 (comment).
To be clear, the intent of this PR is having the Controller GUI properly reflect the current state if it's changed programmatically by Netplay (or anything else). The eventual target (not in this PR) is that during Netplay, the dropdowns for the GC controller ports and Wiimotes will be greyed out (because we don't support them changing mid-session), but the Configure buttons next to them will still work so you can change your mappings, along with harmless-to-Netplay settings like Background Input.