Jit64: Remove breakpoint check from JitAsm.cpp #11077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I barely understand the code in that section, but if jitasm is causing a break, maybe checkbreakpoints could be conditioned on that. Then jit could be left alone to handle log without breaking and any breaks that jit calls itself. |
JosJuice
force-pushed
the
jitasm-no-breakpoint
branch
from
a1129fe
to
178cf2f
Compare
AdmiralCurtiss
approved these changes
Oct 15, 2022
The breakpoint check in Jit.cpp makes it redundant. Normally this redundant check doesn't cause any issues, but if you create a breakpoint and enable logging without breaking, you get two log messages if the breakpoint is at the beginning of a block. See https://bugs.dolphin-emu.org/issues/13044. This is also a tiny performance improvement for when debugging is active, since we no longer check for breakpoints for blocks that never had any breakpoints to begin with.
JosJuice
force-pushed
the
jitasm-no-breakpoint
branch
from
178cf2f
to
b9aed42
Compare
|
Thanks for working on this! Not noticing any issues now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The breakpoint check in Jit.cpp makes it redundant.
Normally this redundant check doesn't cause any issues, but if you create a breakpoint and enable logging without breaking, you get two log messages if the breakpoint is at the beginning of a block. See https://bugs.dolphin-emu.org/issues/13044.
This is also a tiny performance improvement for when debugging is active, since we no longer check for breakpoints for blocks that never had any breakpoints to begin with.