Remove old GCC version workarounds #11081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // XXX: in old GCC versions, capturing 'this' does not work for some lambdas. The workaround | ||
| // is to not use auto for the parameter (even though the type is obvious). | ||
| // This can be dropped once we require GCC 7. | ||
| using CertStructInfo = std::tuple<SignatureType, PublicKeyType, size_t>; |
There was a problem hiding this comment.
I think keeping this using CertStructInfo is more readable.
There was a problem hiding this comment.
Fair enough, I also thought this. Shall I remove the comment, though?
There was a problem hiding this comment.
Yeah, the comment is definitely outdated.
cobalt2727
referenced
this pull request
in cobalt2727/L4T-Megascript
Sep 24, 2022
for jetson orin, only gcc-11 and up have detection for the cpu used with =native
The minimum GCC version is now GCC 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum GCC version is going to become GCC 10. (#10969)