BBA/BuiltIn: Fix a crash during network stack exhaustion #11083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I don't know whether this actually fixes https://bugs.dolphin-emu.org/issues/13032, this looks like a sensible change regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR is an attempt to fix the following crash: https://bugs.dolphin-emu.org/issues/13032
This was the only part of the code I could find where a check was missing that could produce a crash of Dolphin. I'm unsure if it's related to the described issue. Regardless, I managed to exhaust the BBA network stack and crash Dolphin by requesting the UPnP URL with multiple tabs of a web browser.
The PR addresses these issues by:
nullptrdereference crashReady to be reviewed & merged.