Add TVec and RawValue equality operators. #11085
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
Sep 23, 2022
AdmiralCurtiss
force-pushed
the
tvec-equality
branch
from
d5ab386
to
f8f3dda
Compare
leoetlino
approved these changes
Sep 23, 2022
AdmiralCurtiss
force-pushed
the
tvec-equality
branch
from
f8f3dda
to
02a967f
Compare
|
This change (the new operator in ControllerEmu.h) causes Dolphin to fail to compile on my machine (Linux) with the error Not sure if I'm missing anything, in the past I've always been able to compile Dolphin. |
|
Your compiler does not have good C++20 support, which we require since #10740. Update your compiler to at least gcc 10, ideally 11 or higher. |
|
Thanks, switched to a newer gcc/g++ and it's working again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Extracted from #11070 for easy review.