GameSettings: Add patch for Dead to Rights audio #11086
Conversation
This game follows the anti-pattern of calling memset on a buffer in the midst of being DMA copied to ARAM, then calling a DVD read function that effectively cancels the memset with dcbi instructions. Dolphin does not emulate dcache for performance reasons, so this patch removes the offending memset call. Patches are included for two regions and are enabled by default. https://bugs.dolphin-emu.org/issues/12759
|
This (presumably) would solve https://bugs.dolphin-emu.org/issues/12759. |
|
Can confirm the issue and patch make sense. |
|
Oh, so this is basically another instance of the RE3 audio bug? |
|
Is there a third version of this game too? Our wiki suggests there's three versions of this by listing three game IDs, but redump only lists an EU and a US one. Moreover, the EU version does not have a German language listed, which suggests there's a German version with removed blood or something like that, as was pretty common at the time, but that doesn't quite match up with the game IDs on the Wiki... e: I cannot find any evidence of a German copy at all, maybe this just never came out in German? |
|
If there was a separate German version, it wouldn't have the game ID GDRP. To me this just looks like some wiki editor made up a game ID with the wrong maker ID. It has happened before. |
|
Is there anything else to do with this? It might be worth merging to get people playing the game to test it throughout the whole game instead of just focused tests from me. |
This game follows the anti-pattern of calling memset on a buffer in the midst of being DMA copied to ARAM, then calling a DVD read function that effectively cancels the memset with dcbi instructions. Dolphin does not emulate dcache for performance reasons, so this patch removes the offending memset call.
Patches are included for two regions and are enabled by default.
https://bugs.dolphin-emu.org/issues/12759